API diff between .NET 8 Preview 6 and .NET 8 Preview 7 #8675
Conversation
| @@ -0,0 +1,64 @@ | |||
| # System.Numerics | |||
There was a problem hiding this comment.
System.Numerics LGTM.
It's namely the addition of the IUtf8SpanParsable interface and the "left handed" matrix creation APIs
| @@ -0,0 +1,31 @@ | |||
| # System.Runtime.CompilerServices | |||
There was a problem hiding this comment.
System.Runtime.CompilerServices LGTM. New attributes were exposed so Roslyn doesn't have to generate internal polyfills in every assembly.
| @@ -0,0 +1,87 @@ | |||
| # System.Runtime.Intrinsics.Wasm | |||
There was a problem hiding this comment.
System.Runtime.Intrinsics.Wasm LGTM
CC. @radekdoulik
| @@ -0,0 +1,161 @@ | |||
| # System | |||
There was a problem hiding this comment.
System LGTM.
Namely addition of the IUtf8SpanParsable interface
|
|
||
| - public static FrozenSet<T> ToFrozenSet<T>(this IEnumerable<T> source, IEqualityComparer<T>? comparer, bool optimizeForReading); | ||
|
|
||
| } |
| public static class ImmutableStack { | ||
| + public static ImmutableStack<T> Create<T>(ReadOnlySpan<T> items); | ||
| } | ||
| } |
| ``` diff | ||
| namespace System.Text.Unicode { | ||
| public static class Utf8 { | ||
| + public static bool IsValid(ReadOnlySpan<byte> value); |
| + public static class MeterFactoryExtensions { | ||
| + public static Meter Create(this IMeterFactory meterFactory, string name, string? version = null, IEnumerable<KeyValuePair<string, object?>>? tags = null); | ||
| + } | ||
| } |
There was a problem hiding this comment.
I think these moved interfaces from one assembly to other assembly. but existed in preview 5 as I recall.
There was a problem hiding this comment.
Was that movement expected, or are you saying the API diff tool has a bug?
There was a problem hiding this comment.
The move is expected. If we are documenting the API diff difference should be noted as moved and not introduced APIs.
|
|
|
WinForms LGTM. |
Known issues:
{or{}. Please provide a GitHub suggestion in this PR so I can correct it. arcade#10981Repos area owners:
Libraries area owners:
System @dotnet/area-system-runtime
System.Collections @dotnet/area-system-collections
System.Diagnostics.Metrics @tommcdon @noahfalk
System.Net @dotnet/ncl
System.Numerics @dotnet/area-system-numerics
System.Reflection @dotnet/area-system-reflection
System.Runtime.CompilerServices: @dotnet/area-system-runtime-compilerservices
System.Runtime.InteropServices @dotnet/interop-contrib
System.Runtime.Intrinsics @dotnet/area-system-runtime-intrinsics @lewing @radekdoulik
System.Security @dotnet/area-system-security
System.Text.Json @dotnet/area-system-text-json
System.Text @dotnet/area-system-text-encoding
System.Xml @dotnet/area-system-xml
Microsoft.Extensions.DependencyInjection @dotnet/area-extensions-dependencyinjection
Microsoft.Extensions.Diagnostics.Metrics @tommcdon @noahfalk
Microsoft.Extensions.Hosting @dotnet/area-extensions-hosting
Microsoft.Extensions.Http.Logging @dotnet/area-extensions-logging @dotnet/ncl
Microsoft.Extensions.Options @dotnet/area-extensions-options